Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: .markdown-section max-width 800px to 80% #1017

Merged
merged 4 commits into from
Feb 12, 2020
Merged

update: .markdown-section max-width 800px to 80% #1017

merged 4 commits into from
Feb 12, 2020

Conversation

jhoneybee
Copy link
Contributor

@jhoneybee jhoneybee commented Feb 10, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

@jhoneybee jhoneybee changed the title fix: fix: Max-width 800px to 95% Feb 10, 2020
@jhoneybee jhoneybee changed the title fix: Max-width 800px to 95% update: .markdown-section max-width 800px to 95% Feb 10, 2020
@anikethsaha anikethsaha requested a review from a team February 10, 2020 11:31
@anikethsaha
Copy link
Member

@jhoneybee can you please describe the reason or any point for this change

@jhoneybee
Copy link
Contributor Author

jhoneybee commented Feb 10, 2020

@anikethsaha

The reason to modify 800px to percentage is as follows

1. The document is not beautiful under the huge screen.

800px

image

80%

image

Testable by browser zoom

I found 80% is the most beautiful after trying . sorry, because English is not my native language, I answered late

@jhoneybee jhoneybee changed the title update: .markdown-section max-width 800px to 95% update: .markdown-section max-width 800px to 80% Feb 10, 2020
@yzhang-gh
Copy link

I would suggest restoring max-width to 100% if the viewport width is less than 768px.

@media screen and (max-width: 768px)

This PR breaks the layout on mobile devices 😥.

@anikethsaha
Copy link
Member

can you create an issue

@yzhang-gh
Copy link

I created a PR (#1273) as it is so slight a problem.

@yzhang-gh
Copy link

@anikethsaha Could you spare a few minutes to take a look. Thanks.

@jhildenbiddle
Copy link
Member

@anikethsaha --

I know this has already been merged, but setting text width to 80% of the screen resolution is a bad idea. Standard practice for readability is 45-75 characters per line. Here's more detail:

https://www.smashingmagazine.com/2014/09/balancing-line-length-font-size-responsive-web-design/

THE IDEAL MEASURE: 45 TO 75 CHARACTERS

We have multiple “rules” for facilitating a horizontal reading motion, one of which is to set text at a reasonable measure. As James Craig wrote in his book Designing With Type (originally published in 1971, now it its fifth edition):

Reading a long line of type causes fatigue: the reader must move his head at the end of each line and search for the beginning of the next line.… Too short a line breaks up words or phrases that are generally read as a unit.
If a casual reader gets tired of reading a long horizontal line, then they’re more likely to skim the left edge of the text. If an engaged reader gets tired of reading a long horizontal line, then they’re more likely to accidentally read the same line of text twice (a phenomenon known as “doubling”).

65 characters (2.5 times the Roman alphabet) is often referred to as the perfect measure. Derived from this number is the ideal range that all designers should strive for: 45 to 75 characters (including spaces and punctuation) per line for print. Many web designers (including me) apply that rule directly to the web. I’ve found, however, that we can reliably broaden the range to 45 to 85 characters (including spaces and punctuation) per line for web pages.

Filling more of the empty space may be visually preferable to some, but there's little argument to be made that this is better for everyone. My recommendation would be to revert this change and let those who prefer content to stretch for wide monitors to add their own custom CSS to a <style> block in their index.html page.

@anikethsaha
Copy link
Member

@jhildenbiddle how about #1273 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants