-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update language-highlight.md #1263
Conversation
Proposed changes described in comment from #1251
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/54jygogaz |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cd9df2d:
|
Add PHP grammar file for Prism.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Looks good. Do we want to add a note about differences between GitHub and Prism aliases?
I don’t think so, but if folks feel strongly about it I’m happy to add it. Prism’s aliases are a subset of GitHub’s aliases (from what I’ve seen) and everything in our docs references Prism aliases. Point being, as long as people follow our docs, everything will work fine on GitHub. Plus, syntax highlighting is 1) not going to break anything if it doesn’t work and 2) pretty easy to spot when reviewing a social sight. Just my $0.02. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Feel free to merge it when ready
I think due to the state of how far reaching GitHub is in the dev world,
most people expect (without thinking about it) the same aliases like on
GitHub. Truth be told, Markdown was never even a part of my life until
GitHub brought it to me, and things like Prism work in a way I'm not
accustomed to.
#!/JoePea
…On Fri, Jul 3, 2020, 9:23 AM John Hildenbiddle ***@***.***> wrote:
Merged #1263 <#1263> into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1263 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACIVTRHETMQU7B5AVJLD2TRZYAZRANCNFSM4OPKD5WA>
.
|
Proposed changes described in comment from #1251
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
lib
directory.