-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Vue Reactivity #1271
Fix Vue Reactivity #1271
Conversation
- Fix inability to instantiate reactive Vue components by 1) handling each child of #main instead of #main itself and 2) skipping elements that are already Vue instances - Retain previous behavior of processing basic Vue rendering without the need for a markdown <script> tag. - Update documentation and add live Vue examples - Update `index.html` files to include Vue.js and Vuep (CSS+JS)
# Conflicts: # docs/index.html
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/gw3jsrcph |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f6148d:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome ! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good change, but let's add unit tests.
tests fixtures (e2e-cypress) have been updated. But yea unit/integration tests would be great to add. But is it possible to do unit testing for this change ? if so, it would be great to add. |
- When Vue.js is detected, markdown `<script>` is not executed when executeScript is `false` (matches previous behavior) - Minor code tweaks that do not affect functonality
105fbbf
Fixes #788 #790 #1074 #1252 #1364
#main
instead of#main
itself and 2) skipping elements that are already Vue instances<script>
tag.index.html
files to include Vue.jsCypressJest+Playwright e2e testsSummary: Docsify was mounting
#main
as a Vue component on every page change when it detected Vue.js, presumably to process basic Vue content without requiring a<script>
tag in each markdown file. The issue is that this was happening after users had already instantiated child elements of#main
as Vue components, destroying those instances.