Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sources in Universe View can make it look like a per-address source is active, when it is not #248

Closed
hinrichsenhans opened this issue Dec 17, 2021 · 3 comments
Assignees
Labels
enhancement fixed in development branch Fixed in a development branch for the version milestone
Milestone

Comments

@hinrichsenhans
Copy link
Contributor

hinrichsenhans commented Dec 17, 2021

Setup:

  • Open two transmit tabs and a single Universe View in sACN 2.1.2
  • Transmit tab 1: Universe 1, Per-Address Priority, press "..." and set all addresses to priority 0. Set Address 1 alone to 100.
  • Transmit tab 2: Universe 1, Per-Address Priority, no changes to priority map (all at 100)
  • Start transmitting in tab 1, bring the address 1 slider up slightly
  • Universe View (U1): Note that only a single cell is active. Address 1 says it has a winning value from tab 1 at priority 100.
  • Look at Address 2 - it has no sources
  • Start transmitting in tab 2
  • Universe View (U1) now shows for address 2 that there are two active sources. The winning source (from tab 2) at priority 100, and tab 1 at priority 0

image

Internally, I know per-address priority is setting the value to 0, so this is accurate. However, this makes it appear as if we do have that address patched. (It is an implementation detail that a value of 0 is the "not patched" value). Ideally we should show the single source, or show the inactive addresses consistently.

@RichardTea
Copy link
Contributor

Do you actually mean Per-Address mode throughout?

Priority Mode "Per-Source" (default) is "per-universe", so there are no per-address priority values. The [...] button is disabled and all addresses are 'patched' with the same priority.
In that situation, Per-Source priority 0 is an active value (least important).

@hinrichsenhans
Copy link
Contributor Author

Whoops! Yes I do, I'll see if I can edit the original.

@marcusbirkin marcusbirkin self-assigned this Dec 18, 2021
@marcusbirkin marcusbirkin added this to the v2.2 milestone Dec 18, 2021
marcusbirkin added a commit that referenced this issue Dec 18, 2021
docsteer pushed a commit that referenced this issue Jan 30, 2022
docsteer pushed a commit that referenced this issue Jan 30, 2022
docsteer pushed a commit that referenced this issue Jan 30, 2022
@marcusbirkin marcusbirkin added the fixed in development branch Fixed in a development branch for the version milestone label Nov 8, 2022
@docsteer
Copy link
Owner

docsteer commented Mar 8, 2023

Resolved in v2.2.0-beta.1

@docsteer docsteer closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fixed in development branch Fixed in a development branch for the version milestone
Projects
None yet
Development

No branches or pull requests

4 participants