Fix: options not propagated in blocking activity logger

doctolib · Dec 13, 2023 · 315cc23 · 315cc23
1 parent 679ed20
commit 315cc23
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/safe-pg-migrations/plugins/blocking_activity_logger.rb b/lib/safe-pg-migrations/plugins/blocking_activity_logger.rb
@@ -11,6 +11,11 @@ module BlockingActivityLogger
 
     RETRIABLE_SCHEMA_STATEMENTS.each do |method|
       define_method method do |*args, **options, &block|
+        args, options = if args.last.is_a?(Hash)
+                          [args[..-2], args.last]
+                        else
+                          [args, {}]
+                        end
         log_context = lambda do
           break unless SafePgMigrations.config.sensitive_logger
 

diff --git a/test/StatementInsurer/remove_column_test.rb b/test/StatementInsurer/remove_column_test.rb
@@ -55,5 +55,20 @@ def change
 
       assert_equal ['ALTER TABLE "users" DROP COLUMN "name"'], calls[2]
     end
+
+    def test_remove_column_with_default_arguments
+      @connection.create_table(:users) { |t| t.string :name }
+
+      @migration =
+        Class.new(ActiveRecord::Migration::Current) do
+          def change
+            remove_column(:users, :name, :string, null: false, default: 'Benaaaa')
+          end
+        end.new
+
+      calls = record_calls(@connection, :execute) { run_migration }
+
+      assert_equal ['ALTER TABLE "users" DROP COLUMN "name"'], calls[2]
+    end
   end
 end