Add github action #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThHareau
commented
Sep 16, 2020
ThHareau
commented
- Add CI github action
Create workflow
Add only rubocop
* Using local actions * Add RuboCop * Limit to push master and pr * Pull request only * No dependency on test * Using real ruby versions * Update ruby version * options for PG? * Start service * Split * Change service * with env * Remove host * Stop starting the service * Trying other config * idea * Adding password to env * real test script * Add cache * Add rubocop * Install in dedicated script * Fix * Fix fix * Fix fix fix * remove needs
ThHareau
force-pushed
the
create-workflow
branch
from
5d8ec23
to
3dd8ecf
Compare
added 2 commits
September 18, 2020 11:09
ThHareau
commented
Sep 18, 2020
Comment on lines
+17
to
+30
| - uses: doctolib/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ env.RUBY_VERSION }} | ||
| - uses: doctolib/cache@v2 | ||
| with: | ||
| path: vendor/bundle | ||
| key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-gems- | ||
| - name: bundle | ||
| run: | | ||
| gem install bundler | ||
| bundle config path vendor/bundle | ||
| bundle install --jobs 4 --retry 3 |
There was a problem hiding this comment.
I've tried to move this part here in an independent action, but as document in actions/runner#438 it is not yet possible to use other actions in composite actions.
Apparently github is working on it, once done we could have an internal action in a repo that we can use in any of our repo.
There was a problem hiding this comment.
That would also make the file a lot shorter :)
bpaquet
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.