Declare conflict against "doctrine/orm" >= 2.10 in order to guarantee the schema extension #2255
Conversation
phansys
changed the title
phansys
force-pushed
the
schema_extension
branch
from
b1797f8 to
2a7a87e
Compare
|
Aha, yeah that'll do it. 😓 Any idea what the developer experience will be for anyone updating their Composer dependencies? Are they going to get a straight conflict and unable to upgrade Doctrine ORM/DBAL? How soon can we get compatible? |
|
IIUC, the approach suggested by "doctrine/orm" is to declare the full validation schema in our side. IMO, we should discuss about how to implement the "pull" mechanism from the base schema, in order to avoid outdated definitions. |
Every consumer of this package will be required to use ORM 2.9 and earlier. Anyone trying to add this package after being on ORM 2.10 (which potentially also includes DBAL 3.x) might run into conflicts trying to downgrade their dependencies. |
I think the current situation is worst for users using "doctrine/orm" 2.10, since the features provided by this package are not working at all (as you can see in some recent checks). |
|
Right. Not ideal, but necessary for now. Is there anything else in flight that's critical or very useful for a next release? Worth getting this out quickly. |
|
Sounds reasonable. Thank you so much for your contributions lately, Javier. Just give me a second to get the changelog updated after merging before you rebase. |
I can add the changelog on my side for this PR if you agree. |
|
Please do, makes my life easier 😄 |
… the schema extension
phansys
force-pushed
the
schema_extension
branch
from
2a7a87e to
e5b1c8c
Compare
|
🙌🏼 |
…uarantee the schema extension (doctrine-extensions#2255)" This reverts commit 12f41d3.
… the schema extension (doctrine-extensions#2255)
… the schema extension (doctrine-extensions#2255)
"doctrine/orm" 2.10.0 removes the possibility to extend the mapping schema, so we must provide our own validation schema in order to support this version.
See doctrine/orm#8852.