Skip to content

Commit

Permalink
Remove quotes
Browse files Browse the repository at this point in the history
In the case of a pull request made from a fork, secrets are not
accessible, and this resolved to null.
The codecov action seems to interpret null as no secret provided, while
it interprets the empty string as an invalid token, making the whole
tokenless upload invalid.
  • Loading branch information
greg0ire committed Aug 15, 2024
1 parent 36c5f05 commit d59ff74
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions workflow-templates/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
with:
php-versions: '["6.0", "6.1"]' # Use custom versions of PHP
secrets:
CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}"
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

phpunit-unstable-symfony:
name: "PHPUnit with unstable Symfony"
Expand All @@ -39,4 +39,4 @@ jobs:
# If the package requires some components but does not allow that version yet
extra-requirements: "symfony/framework-bundle 47.1.x symfony/console 47.1.x"
secrets:
CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}"
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

0 comments on commit d59ff74

Please sign in to comment.