-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce coding standards workflow #2
Conversation
This comment has been minimized.
This comment has been minimized.
9561432
to
b13db7e
Compare
04a39a6
to
5ca9d55
Compare
5ca9d55
to
e781db2
Compare
jobs: | ||
coding-standards: | ||
name: "Coding Standards" | ||
runs-on: "ubuntu-20.04" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20.04 is documented as "preview only", apparently latest
still resolves to 18.04
if we believe these docs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idruns-on
Tell me if I should use 18.04 here of if you think it's fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I preferred latest so we don't have to keep updating this string... I don't care about actual version used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd try to use the newest one that works. This way, we won't have to update the workflow too soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I preferred latest so we don't have to keep updating this string
If we use templates the need to update will only be on this repo, so no longer such a big deal.
e781db2
to
86ab86f
Compare
86ab86f
to
aa0c338
Compare
aa0c338
to
279cea2
Compare
279cea2
to
a1e3ec1
Compare
I see some point in why that is. The action depends on certain APIs but doesn't own the dependency constraint, so it may be challenging to maintain it once it's shared between projects. The question is, what is the purpose of this shared workflow once all projects are on board? I.e. is there a way to synchronize them with the updates upstream? Otherwise, it may just stale overtime. |
I'm hoping to find that out by getting doctrine/annotations#357 merged and then seeing if there are any changes in the UI above. But maybe somebody well-versed in this already knows. @localheinz maybe? |
As far as I understood, these templates are really only templates to simplify creation of workflows for repositories within an organization. As such, they do not propagate as actual workflows to repositories within an organization. |
Yes, what I'm hoping is that once you create one, it does not propose to "setup the workflow", but rather to synchronize it (by making another commit). |
This is a copy of the coding standards workflow I introduced in
doctrine/annotations
, with a few changes:doctrine/annotations
I'm deliberately naming the file with a very narrow scope, so that it's easy to enable or disable workflows based on the repository we are using.