Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes #48

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Remove quotes #48

merged 1 commit into from
Aug 15, 2024

Conversation

greg0ire
Copy link
Member

In the case of a pull request made from a fork, secrets are not accessible, and this resolved to null.
The codecov action seems to interpret null as no secret provided, while it interprets the empty string as an invalid token, making the whole tokenless upload invalid.

In the case of a pull request made from a fork, secrets are not
accessible, and this resolved to null.
The codecov action seems to interpret null as no secret provided, while
it interprets the empty string as an invalid token, making the whole
tokenless upload invalid.
@greg0ire greg0ire merged commit d3d1632 into doctrine:main Aug 15, 2024
@greg0ire greg0ire deleted the remove-quotes branch August 15, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants