fix: Prefer primary config over master.

[prengerjarno]

Make sure the primary config gets used over the master so it uses the added options when PrimaryReadReplicaConnection is used. #1257

[ostrolucky]

New primary config was added in 2.2, so this is the branch this should point to.

Also, I'm not really understanding the fix. Why is primary getting overwritten with master if you specify primary?

[prengerjarno]

@ostrolucky I'm sorry, its not the config, its the params. Both 'master' and 'primary' params are present to because of the BC support in doctrine/dbal's MasterSlaveConnection. In this case it should use the 'primary' params, but is using the 'master' which is missing the 'driver' option (because it only gets added to 'primary' in PrimaryReadReplicaConnection::__construct).

[ostrolucky]

If DBAL is adding driver to primary only and not to master, that's a bug in DBAL's BC layer and you need to report issue there.

[stof]

@ostrolucky ->getParams is an API marked as internal.

[ostrolucky]

Up to dbal 2.11 initiating connection with master would result in getParams giving you back array including master['driver'] and then it was changed because in 2.11 it was marked internal and that's ok? That's not how BC works. Method cannot be broken in minor release like that and claim it's ok because it's internal now. It can be broken in 3.x, not in 2.x.

[greg0ire]

I managed to trigger a build.

[greg0ire]

Thanks @prengerjarno