Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility for Symfony 6 projects without doctrine/persistence 3 support #1841

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Nov 21, 2024

Sadly this PR #1832 make projects which do not have compatibility to Symfony 6.4 Doctrine Bridge (like Sulu 2.5 version) yet fail because of using not yet supporting doctrine/persistence 3. Symfony 6.4 doctrine bridge requires atleast doctrine/persistence 3 but some projects may are on Symfony 6 still on version 2.

Composer instead of downgrading to / keep 2.13.0 it downgrades doctrine/bridge to 5.4.46 which ends up in another failure:

Bildschirmfoto 2024-11-21 um 10 41 52

"Declaration of Symfony\Bridge\Doctrine\PropertyInfo\DoctrineExtractor::getProperties(string $class, array $context = []) must be compatible with Symfony\Component\PropertyInfo\PropertyListExtractorInterface::getProperties(string $class, array $context = []): ?array

Sure projects using flex would not run into that. But to avoid this error on libs without flex and with a wider range of support symfony version we should also add the version of 6.3.12 released with the 6.4.3 to still support Symfony 6 + Doctrine Persistence 2.

@MatTheCat

@ostrolucky ostrolucky added the Bug label Nov 21, 2024
@ostrolucky ostrolucky added this to the 2.13.2 milestone Nov 21, 2024
@ostrolucky ostrolucky merged commit 7564fa7 into doctrine:2.13.x Nov 22, 2024
16 checks passed
@alexander-schranz alexander-schranz deleted the patch-1 branch November 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants