Ensure classes using the #[Entity] attribute are not declared as service
#1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
exclude-entities
branch
2 times, most recently
from
b1f7454 to
d5297d7
Compare
SenseException
approved these changes
Feb 8, 2025
ostrolucky
reviewed
Feb 9, 2025
GromNaN
force-pushed
the
exclude-entities
branch
from
ac60cf1 to
c33b49d
Compare
GromNaN
force-pushed
the
exclude-entities
branch
from
c33b49d to
bbcce03
Compare
|
this should also exclude MappedSuperclass and Embeddable |
GromNaN
force-pushed
the
exclude-entities
branch
from
bbcce03 to
3a31649
Compare
dunglas
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable discovery of entity classes by the Symfony DIC, we need to exclude them from being registered as actual services.
src/Entity/directory from thesymfony/framework-bundlerecipe.#[ApiResource]attribute can be discovered using DI instead of using a custom-made mechanism of directory scanning and cache: feat(symfony): Autoconfigure classes using#[ApiResource]attribute api-platform/core#6943Definition::addExcludedTag()andContainerBuilder::findExcludedServiceIds()for auto-discovering value-objects symfony/symfony#59704#[Document]attribute from container DoctrineMongoDBBundle#876