Update dependencies #260
Merged
Update dependencies #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
driehle
commented
Mar 22, 2022
•
driehle
commented
- Marks 3.2 series as unmaintained
- Updates dependencies to latest versions
- Fixes one static analysis issue occuring with newer version of Psalm
driehle
force-pushed
the
feature/dependencies
branch
from
88a5220 to
66f5dc6
Compare
malarzm
requested changes
Mar 22, 2022
| "doctrine/mongodb-odm": "^2.3.0", | ||
| "doctrine/persistence": "^2.2.3", | ||
| "doctrine/mongodb-odm": "^2.3.2", | ||
| "doctrine/persistence": "^2.4.0", |
There was a problem hiding this comment.
What's the point in bumping doctrine/persistence? ODM itself is fine with ^2.2
There was a problem hiding this comment.
Why not? Since it is the same major there shouldn't be any issues in upgrading.
There was a problem hiding this comment.
Probably best done in a minor release, rather than a patch release
| "doctrine/doctrine-module": "^5.0.0", | ||
| "doctrine/doctrine-laminas-hydrator": "^2.2.1 || ^3.0.0", | ||
| "doctrine/doctrine-module": "^5.1.0", | ||
| "doctrine/doctrine-laminas-hydrator": "^3.0.1", |
There was a problem hiding this comment.
What's the point in dropping ^2.2.1? That's really drastic for a bugfix release
There was a problem hiding this comment.
2.2 series will soon be unmaintained
malarzm
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.