Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue with DoctrineModule 5.2.0 #263

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

driehle
Copy link
Member

@driehle driehle commented Oct 26, 2022

Since DoctrineMongoODMModule 4.0.x is officially not maintained anymore, I am releasing a fix to mark this module as incompatible to DoctrineModule >= 5.2.0.

For the 4.1.x series I am hoping to get this running again with a new release of DoctrineModule.

@driehle driehle added the Bug Something isn't working label Oct 26, 2022
@driehle driehle added this to the 4.0.1 milestone Oct 26, 2022
@driehle driehle requested a review from malarzm October 26, 2022 08:38
@driehle driehle self-assigned this Oct 26, 2022
@driehle driehle force-pushed the fix/doctrine-module-compatibility branch 2 times, most recently from e261cd4 to 473a6bc Compare October 26, 2022 08:42
@driehle driehle requested a review from a team October 26, 2022 13:49
@driehle driehle force-pushed the fix/doctrine-module-compatibility branch from e0e6041 to 8e43a30 Compare October 26, 2022 15:54
@driehle driehle force-pushed the fix/doctrine-module-compatibility branch from 8e43a30 to 7c0974d Compare October 26, 2022 15:55
@driehle
Copy link
Member Author

driehle commented Oct 26, 2022

There we go, CI back working 💪

The change causing the issue was in DoctrineModule 5.2.0 in DriverFactory.php, see doctrine/DoctrineModule@5.1.1...5.2.0

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the changes but am a simple man: I see @Ocramius' apprive I'll give one too :)

@driehle driehle merged commit c1c4fae into doctrine:4.0.x Oct 26, 2022
@driehle driehle deleted the fix/doctrine-module-compatibility branch November 7, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants