Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typed properties where possible #703

Merged
merged 6 commits into from
Jan 2, 2022

Conversation

driehle
Copy link
Member

@driehle driehle commented Dec 31, 2021

As the upcoming 5.0.0 release of DoctrineORMModule will require PHP 7.4 at least, we can use typed properties in all places. Obviously, this will be a BC break in several places, but we should accept that in favour of code quality improvements. As 5.0.0 is a major release, this should be fine.

This is currently based on #702, as it requires DoctrineModule 5.0, which is strongly typed as well.

@driehle driehle self-assigned this Dec 31, 2021
@driehle driehle added this to the 5.0.0 milestone Dec 31, 2021
@driehle driehle requested review from greg0ire, SenseException and a team December 31, 2021 12:33
@driehle driehle marked this pull request as ready for review December 31, 2021 12:33
@driehle driehle merged commit 7e1172f into doctrine:5.0.x Jan 2, 2022
@driehle driehle deleted the feature/typed-properties branch January 2, 2022 17:00
@driehle driehle added the Enhacement New feature or request label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Enhacement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants