Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP 7.4 #738

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Drop PHP 7.4 #738

merged 2 commits into from
Jun 8, 2023

Conversation

demiankatz
Copy link
Contributor

@demiankatz demiankatz commented Jun 8, 2023

As proposed on #734, this PR drops support for PHP 7.4, since it has passed end of life. This may simplify some of our continuous integration issues.

TODO

  • Make style check pass

@demiankatz
Copy link
Contributor Author

I based this on doctrine/DoctrineModule@5d6f2aa -- pretty sure I didn't miss anything. We'll see if CI passes. :-)

@demiankatz
Copy link
Contributor Author

Looks like everything is passing except style checks -- raising the PHP version has allowed the style checker to make some new suggestions. @greg0ire / @TomHAnderson, would you like me to implement these changes? I'm willing to, but won't invest time in it until I'm sure somebody wants me to. :-)

@demiankatz demiankatz mentioned this pull request Jun 8, 2023
5 tasks
@TomHAnderson
Copy link
Member

Laminas has moved past 7.4 so I'm comfortable with this PR. Please keep up your excellent work.

@demiankatz
Copy link
Contributor Author

demiankatz commented Jun 8, 2023

Thanks, @TomHAnderson -- since I had some momentum, I figured I might as well use it to clean up the styles here, so I believe this is ready to merge now if you're willing. I guess the only question is whether this requires a 6.0.x branch or not -- I'm unsure of the release practices here.

@TomHAnderson TomHAnderson added this to the 6.0.0 milestone Jun 8, 2023
@TomHAnderson TomHAnderson changed the base branch from 5.4.x to 6.0.x June 8, 2023 16:04
@TomHAnderson TomHAnderson merged commit 300b6ec into doctrine:6.0.x Jun 8, 2023
@demiankatz demiankatz deleted the drop-php-7 branch June 8, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants