Slevomat ReturnTypeHintSpacing: remove default spacesCountBeforeColon configuration #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CountBeforeColon configuration that is the default
greg0ire
previously approved these changes
Jun 18, 2020
morozov
reviewed
Jun 18, 2020
| @@ -368,11 +368,7 @@ | |||
| <!-- Require one space between typehint and variable, require no space between nullability sign and typehint --> | |||
| <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHintSpacing"/> | |||
| <!-- Require space around colon in return types --> | |||
There was a problem hiding this comment.
This comment is no longer valid. The space is required only after the colon.
There was a problem hiding this comment.
also, the included psr12 sniffs enforce this. the comment seems redundant and can be removed?
SenseException
previously approved these changes
Jun 20, 2020
|
I can promise I'll not change it :D |
greg0ire
dismissed stale reviews from SenseException and themself
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed to zero here: #163
But this is the default so no need for the override: https://github.com/slevomat/coding-standard/blob/c4e287879af90a2f56b1b516deaba707858c9a24/SlevomatCodingStandard/Sniffs/TypeHints/ReturnTypeHintSpacingSniff.php#L35