Remove PSR12.Properties.ConstantVisibility in favor of slevomat #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
What are the benefits of using Slevomat's rule instead of PHPCS'?
Does it check more stuff or stricter?
I always like to think as well: slevomat/coding-standard is an extension for PHPCS. The less we depend on it, better! We might remove it one day as PHPCS is going to cover everything.
|
|
If you want my opinion I would prefer using the phpcs one instead of slevomat even without the autofix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isn't this already checked by slevomat?
Does the one cover cases that the other does not? Then if yes.. shouldn't the
PSR12.Properties.ConstantVisibilitybe turned to anerror.. because currently it is a warning