Extra test scenarios

tests/fixed/UselessConditions.php

@@ -19,6 +19,11 @@ public function uselessIfCondition(): bool
         return $bar === 'bar';
     }
 
+    public function uselessIfConditionWithComment(): bool
+    {
+        return $bar === 'bar';
+    }
+
     public function uselessNegativeCondition(): bool
     {
         return $foo === 'foo';

tests/fixed/array_indentation.php

@@ -3,7 +3,7 @@
 declare(strict_types=1);
 
 $array = [
-    0,
+    0, // this is the first index
     1,
     2,
     3,

tests/fixed/doc-comment-spacing.php

@@ -46,7 +46,8 @@ public function c(iterable $foo): void
      * @deprecated
      *
      * @link https://example.com
-     * @see  other
+     * @see  Something else and make this see annotation
+     *       multiline
      * @uses other
      *
      * @ORM\Id
@@ -67,4 +68,38 @@ public function c(iterable $foo): void
     public function d(iterable $foo, iterable $bar): iterable
     {
     }
+
+    /**
+     * Description
+     * More Description
+     *
+     * @internal
+     * @deprecated
+     *
+     * @link https://example.com
+     * @see  other
+     * @uses other
+     *
+     * @ORM\Id
+     * @ORM\Column
+     * @ODM\Id
+     * @ODM\Column
+     * @PHPCR\Uuid
+     * @PHPCR\Field
+     *
+     * @param int[] $foo
+     * @param int[] $bar
+     *
+     * @return int[]
+     *
+     * @throws FooException
+     * @throws BarException
+     *
+     * @phpstan-param string $foo
+     * @psalm-param string $foo
+     * @phpstan-return true
+     */
+    public function f(iterable $foo, iterable $bar): iterable
+    {
+    }
 }

tests/fixed/forbidden-functions.php

@@ -4,6 +4,7 @@
 
 namespace Test;
 
+use function array_map;
 use function chop;
 use function compact;
 use function extract;
@@ -28,3 +29,5 @@
 extract($bar);
 
 compact('foo', 'bar');
+
+array_map('is_null', ['1', '2', null]); // forbidden function will not be detected

tests/fixed/optimized-functions.php

@@ -4,3 +4,4 @@
 
 $args = [123, [123], true];
 in_array(...$args);
+in_array(...$args);

tests/fixed/semicolon_spacing.php

@@ -9,3 +9,6 @@
 $qb->select()
     ->from()
     ->where();
+
+$qb->select()
+    ->from('mytable'); // we select from my table

tests/fixed/superfluous-naming.php

@@ -12,6 +12,10 @@ class FooException extends RuntimeException
 {
 }
 
+class FooError extends Error
+{
+}
+
 interface FooInterface
 {
 }

tests/fixed/trailing_comma_on_array.php

@@ -6,3 +6,8 @@
     'key1' => 'value',
     'key2' => 'value',
 ];
+
+$arrayWithComment = [
+    'key1' => 'value',
+    'key2' => 'value', // comment
+];

tests/fixed/useless-semicolon.php

@@ -13,3 +13,17 @@
 for (;;) {
     echo 'To infity and beyond';
 }
+
+for (
+    $i = 0; $i < 10;
+    $i++
+);
+{
+    echo 'This will not be executed inside the for-loop';
+}
+
+{
+    $var = 'This is useless';
+};
+
+$myvar = 3;

tests/input/UselessConditions.php

@@ -27,6 +27,17 @@ public function uselessIfCondition(): bool
         return false;
     }
 
+    public function uselessIfConditionWithComment(): bool
+    {
+        if ($bar === 'bar') {
+            // Return true here in case $bar is bar
+            return true;
+        }
+
+        // Return true here in case $bar is bar
+        return false;
+    }
+
     public function uselessNegativeCondition(): bool
     {
         if ($foo !== 'foo') {

tests/input/array_indentation.php

@@ -3,7 +3,7 @@
 declare(strict_types=1);
 
 $array = [
-0,
+0, // this is the first index
  1,
   2,
    3,

tests/input/doc-comment-spacing.php

@@ -57,10 +57,40 @@ public function c(iterable $foo): void
      * @PHPCR\Field
      * @ODM\Column
      * @ORM\Column
-     * @see  other
+     * @see  Something else and make this see annotation
+     *       multiline
      *
      */
     public function d(iterable $foo, iterable $bar): iterable
     {
     }
+
+    /**
+     *
+     * Description
+     * More Description
+     * @phpstan-param string $foo
+     * @psalm-param string $foo
+     * @phpstan-return true
+     * @throws FooException
+     * @param int[] $foo
+     * @uses other
+     * @throws BarException
+     * @return int[]
+     * @ORM\Id
+     * @internal
+     * @link https://example.com
+     * @ODM\Id
+     * @deprecated
+     * @PHPCR\Uuid
+     * @param int[] $bar
+     * @PHPCR\Field
+     * @ODM\Column
+     * @ORM\Column
+     * @see  other
+     *
+     */
+    public function f(iterable $foo, iterable $bar): iterable
+    {
+    }
 }

tests/input/example-class.php

@@ -23,6 +23,7 @@ class Example implements \IteratorAggregate
 {
     private const VERSION = \PHP_VERSION - (PHP_MINOR_VERSION * 100) - PHP_PATCH_VERSION;
 
+
     /** @var null|int */
     private $foo;
 

tests/input/forbidden-functions.php

@@ -28,3 +28,5 @@
 extract($bar);
 
 compact('foo', 'bar');
+
+array_map('is_null', ['1', '2', null]); // forbidden function will not be detected

tests/input/optimized-functions.php

@@ -4,3 +4,4 @@
 
 $args = [123, [123], true];
 in_array(...$args);
+\in_array(...$args);

tests/input/semicolon_spacing.php

@@ -11,3 +11,7 @@
     ->from()
     ->where()
 ;
+
+$qb->select()
+    ->from('mytable') // we select from my table
+;

tests/input/superfluous-naming.php

@@ -12,6 +12,10 @@ class FooException extends RuntimeException
 {
 }
 
+class FooError extends Error
+{
+}
+
 interface FooInterface
 {
 }

tests/input/trailing_comma_on_array.php

@@ -6,3 +6,8 @@
     'key1' => 'value',
     'key2' => 'value'
 ];
+
+$arrayWithComment = [
+    'key1' => 'value',
+    'key2' => 'value' // comment
+];

tests/input/useless-semicolon.php

@@ -7,9 +7,20 @@
 };
 
 do {
-    echo 1;
+    ;echo 1;
 } while (! false);
 
 for (;;) {
     echo 'To infity and beyond';
 };
+
+for ($i = 0 ; $i < 10; $i++);
+{
+    echo 'This will not be executed inside the for-loop';
+}
+
+{
+    $var = 'This is useless';
+};
+
+$myvar = 3;;