PHPStan already supports array-key as template type variable bound

[ondrejmirtes]

It's now even counter-productive to leave @phpstan-template there.

[greg0ire]

We are ignoring a message right now, and it just changed:

- Array (array<TKey, T>) does not accept key int.
+ Array (array<TKey of (int|string), T>) does not accept key int.

That's about

collections/lib/Doctrine/Common/Collections/ArrayCollection.php

Line 312 in 9491825

$this->elements[] = $element;

which is described at

collections/lib/Doctrine/Common/Collections/ArrayCollection.php

Lines 50 to 53 in 9491825

	* @psalm-var array<TKey,T>
	* @var mixed[]
	*/
	private $elements;

I don't understand why it still fails… array<TKey of (int|string), T> should accept key int, shouldn't it?

[ondrejmirtes]

I'll update the ignore, sorry.

The error message tells you that if the user has ArrayCollection<string, Foo>, the method add() will break the key type as it inserts an int.

[greg0ire]

LGTM 🙂

[greg0ire]

🤔 didn't notice the Psalm issue, sorry! It's pre-existing it seems.

[greg0ire]

I'll ignore it in an extra commit.

[greg0ire]

Thanks @ondrejmirtes !

[ondrejmirtes]

Thank you!