Extract factory methods from Doctrine\DBAL\SQLParserUtilsException

Extract Doctrine\DBAL\SQLParserUtilsException::missingParam() Extract Doctrine\DBAL\SQLParserUtilsException::missingType()
doctrine · May 12, 2018 · 7b5f2f8 · 7b5f2f8
1 parent e48f134
commit 7b5f2f8
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 21 deletions.
diff --git a/lib/Doctrine/DBAL/Exception/MissingSQLParam.php b/lib/Doctrine/DBAL/Exception/MissingSQLParam.php
@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\DBAL\Exception;
+
+use Doctrine\DBAL\SQLParserUtilsException;
+use function sprintf;
+
+final class MissingSQLParam extends SQLParserUtilsException
+{
+    public static function new(string $paramName) : self
+    {
+        return new self(
+            sprintf('Value for :%1$s not found in params array. Params array key should be "%1$s"', $paramName)
+        );
+    }
+}
diff --git a/lib/Doctrine/DBAL/Exception/MissingSQLType.php b/lib/Doctrine/DBAL/Exception/MissingSQLType.php
@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\DBAL\Exception;
+
+use Doctrine\DBAL\SQLParserUtilsException;
+use function sprintf;
+
+final class MissingSQLType extends SQLParserUtilsException
+{
+    public static function new(string $typeName) : self
+    {
+        return new self(
+            sprintf('Value for :%1$s not found in types array. Types array key should be "%1$s"', $typeName)
+        );
+    }
+}
diff --git a/lib/Doctrine/DBAL/SQLParserUtils.php b/lib/Doctrine/DBAL/SQLParserUtils.php
@@ -2,6 +2,8 @@
 
 namespace Doctrine\DBAL;
 
+use Doctrine\DBAL\Exception\MissingSQLParam;
+use Doctrine\DBAL\Exception\MissingSQLType;
 use const PREG_OFFSET_CAPTURE;
 use function array_fill;
 use function array_key_exists;
@@ -236,9 +238,9 @@ private static function extractParam($paramName, $paramsOrTypes, $isParam, $defa
         }
 
         if ($isParam) {
-            throw SQLParserUtilsException::missingParam($paramName);
+            throw MissingSQLParam::new($paramName);
         }
 
-        throw SQLParserUtilsException::missingType($paramName);
+        throw MissingSQLType::new($paramName);
     }
 }
diff --git a/lib/Doctrine/DBAL/SQLParserUtilsException.php b/lib/Doctrine/DBAL/SQLParserUtilsException.php
@@ -14,23 +14,4 @@
  */
 class SQLParserUtilsException extends DBALException
 {
-    /**
-     * @param string $paramName
-     *
-     * @return \Doctrine\DBAL\SQLParserUtilsException
-     */
-    public static function missingParam($paramName)
-    {
-        return new self(sprintf('Value for :%1$s not found in params array. Params array key should be "%1$s"', $paramName));
-    }
-
-    /**
-     * @param string $typeName
-     *
-     * @return \Doctrine\DBAL\SQLParserUtilsException
-     */
-    public static function missingType($typeName)
-    {
-        return new self(sprintf('Value for :%1$s not found in types array. Types array key should be "%1$s"', $typeName));
-    }
 }