refactor out getting old column comment

doctrine · Oct 16, 2018 · 8a7208d · 8a7208d
1 parent 7702023
commit 8a7208d
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php b/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php
@@ -580,11 +580,8 @@ public function getAlterTableSQL(TableDiff $diff)
                 }
             }
 
-            $oldComment = null;
             $newComment = $this->getColumnComment($column);
-            if (null !== $columnDiff->fromColumn) {
-                $oldComment = $this->getColumnComment($columnDiff->fromColumn);
-            }
+            $oldComment = $this->getOldColumnComment($columnDiff);
 
             if ($columnDiff->hasChanged('comment') || ($columnDiff->fromColumn !== null && $oldComment !== $newComment)) {
                 $commentsSQL[] = $this->getCommentOnColumnSQL(
@@ -1254,4 +1251,9 @@ private function isNumericType(Type $type) : bool
     {
         return $type instanceof IntegerType || $type instanceof BigIntType;
     }
+
+    private function getOldColumnComment(ColumnDiff $columnDiff) : ?string
+    {
+        return $columnDiff->fromColumn ? $this->getColumnComment($columnDiff->fromColumn) : null;
+    }
 }