Invert condition

It contradicts the message.
doctrine · May 31, 2023 · b94a87f · b94a87f
1 parent 9ccd199
commit b94a87f
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/Schema/TableDiff.php b/src/Schema/TableDiff.php
@@ -180,7 +180,7 @@ public function __construct(
         $this->changedForeignKeys = $changedForeignKeys;
         $this->removedForeignKeys = $removedForeignKeys;
 
-        if ($fromTable !== null) {
+        if ($fromTable === null) {
             Deprecation::trigger(
                 'doctrine/dbal',
                 'https://github.com/doctrine/dbal/pull/5678',

diff --git a/tests/Schema/TableDiffTest.php b/tests/Schema/TableDiffTest.php
@@ -6,11 +6,14 @@
 use Doctrine\DBAL\Schema\Identifier;
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\Schema\TableDiff;
+use Doctrine\Deprecations\PHPUnit\VerifyDeprecations;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class TableDiffTest extends TestCase
 {
+    use VerifyDeprecations;
+
     /** @var AbstractPlatform&MockObject */
     private AbstractPlatform $platform;
 
@@ -53,4 +56,25 @@ public function testReturnsNewName(): void
 
         self::assertEquals(new Identifier('bar'), $tableDiff->getNewName());
     }
+
+    public function testOmittingFromTableInConstructorIsDeprecated(): void
+    {
+        $this->expectDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/5678');
+        $tableDiff = new TableDiff('foo');
+    }
+
+    public function testPassingFromTableToConstructorIsDeprecated(): void
+    {
+        $this->expectNoDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/5678');
+        $tableDiff = new TableDiff(
+            'foo',
+            [],
+            [],
+            [],
+            [],
+            [],
+            [],
+            new Table('foo'),
+        );
+    }
 }