Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate stuff removed in 3.0 #3580

Closed
jwage opened this issue May 31, 2019 · 1 comment · Fixed by #3708
Closed

Deprecate stuff removed in 3.0 #3580

jwage opened this issue May 31, 2019 · 1 comment · Fixed by #3708
Assignees
Labels
Deprecation Hacktoberfest Good issue for participating in Hacktoberfest
Milestone

Comments

@jwage
Copy link
Member

jwage commented May 31, 2019

Going to rework the following in to a list of deprecations that are needed for 2.x

BC BREAK: Changes in the Doctrine\DBAL\Event API

  • SchemaAlterTableAddColumnEventArgs::addSql() and the same method in other SchemaEventArgs-based classes no longer accept an array of SQL statements. They accept a variadic string.
  • ConnectionEventArgs::getDriver(), ::getDatabasePlatform() and ::getSchemaManager() methods have been removed. The connection information can be obtained from the connection which is available via ::getConnection().
  • SchemaColumnDefinitionEventArgs::getDatabasePlatform() and SchemaIndexDefinitionEventArgs::getDatabasePlatform() have been removed for the same reason as above.

BC BREAK: Changes in the Doctrine\DBAL\Connection API

  • The following methods have been removed as leaking internal implementation details: ::getHost(), ::getPort(), ::getUsername(), ::getPassword().
  • The ::getDatabase() method can now return null which means that no database is currently selected.

BC BREAK: Changes in Doctrine\DBAL\Driver\SQLSrv\LastInsertId

  • The class stores the last inserted ID as a nullable string, not an integer, which is reflected in the method signatures.

BC BREAK: Changes in the Doctrine\DBAL\Schema API

  • Method Doctrine\DBAL\Schema\AbstractSchemaManager::_getPortableViewDefinition() no longer optionally returns false. It will always return a Doctrine\DBAL\Schema\View instance.
  • Method Doctrine\DBAL\Schema\Comparator::diffTable() now optionally returns null instead of false.
  • Property Doctrine\DBAL\Schema\TableDiff::$newName is now optionally null instead of false.
  • Method Doctrine\DBAL\Schema\AbstractSchemaManager::tablesExist() no longer accepts a string. Use Doctrine\DBAL\Schema\AbstractSchemaManager::tableExists() instead.
  • Method Doctrine\DBAL\Schema\OracleSchemaManager::createDatabase() no longer accepts null for $database argument.
  • Removed unused method Doctrine\DBAL\Schema\AbstractSchemaManager::_getPortableFunctionsList()
  • Removed unused method Doctrine\DBAL\Schema\AbstractSchemaManager::_getPortableFunctionDefinition()
  • Removed unused method Doctrine\DBAL\Schema\OracleSchemaManager::_getPortableFunctionDefinition()
  • Removed unused method Doctrine\DBAL\Schema\SqliteSchemaManager::_getPortableTableIndexDefinition()

BC BREAK: Changes in the Doctrine\DBAL\Driver API

  1. The $username and $password arguments of ::connect() are no longer nullable. Use an empty string to indicate empty username or password.
  2. The return value of ::getDatabase() has been documented as nullable since some of the drivers allow establishing a connection without selecting a database.

BC BREAK: Doctrine\DBAL\Driver::getName() removed

The Doctrine\DBAL\Driver::getName() has been removed.

@jwage jwage added this to the 2.10.0 milestone May 31, 2019
@morozov morozov added the Hacktoberfest Good issue for participating in Hacktoberfest label Oct 27, 2019
beberlei added a commit to beberlei/dbal that referenced this issue Mar 7, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 7, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 11, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 11, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 22, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 27, 2021
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
beberlei added a commit to beberlei/dbal that referenced this issue Mar 27, 2021
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
beberlei added a commit to beberlei/dbal that referenced this issue Mar 27, 2021
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
beberlei added a commit to beberlei/dbal that referenced this issue Mar 27, 2021
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
beberlei added a commit to beberlei/dbal that referenced this issue Mar 27, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Deprecation Hacktoberfest Good issue for participating in Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants