-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen doctrine/common requirement #2260
Conversation
@@ -13,7 +13,7 @@ | |||
], | |||
"require": { | |||
"php": ">=5.3.2", | |||
"doctrine/common": ">=2.4,<2.6-dev" | |||
"doctrine/common": "~2.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this one. /cc @Ocramius
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably move it to <2.7-dev
Also update dev-master branch-alias to be in line with master branch
@@ -28,7 +28,7 @@ | |||
}, | |||
"extra": { | |||
"branch-alias": { | |||
"dev-master": "2.5.x-dev" | |||
"dev-master": "2.6.x-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is both unrelated, and unneeded. Composer only respects the alias on the actual master branch.
Moved to #2268 |
…ommon-requirement #2260 - loosening doctrine/common requirement: allowing 2.6.x
To be honest, this put your package with requirements >= PHP 5.4 cause doctrine/common 2.6.x requirements are php >= 5.5. This force us (PrestaShop team) to explicitely declare the version of doctrine/common we want to require :( => PrestaShop/PrestaShop#5187 Is that intended ? |
Uhhh... no? Composer will resolve to |
Nope, with "doctrine/dbal": "~2.5.3" we get "doctrine/common": "2.6.1" and "doctrine/dbal" in 2.5.4. |
@mickaelandrieu that depends on the version of PHP that you have installed? People running Precambrian tech will simply get |
@Ocramius weird, Composer does'nt works as expected on this point :/ We got a developper from our team able to install doctrine/common 2.6 with PHP 5.4 installed .. But it's not related to your package, it's probably an issue of composer :/ Sorry for disturbing and thank you for your time :) |
@mickaelandrieu check CLI vs WEB envs |
Ok got it <3 We just forgot to update dependencies after switching php versions 🍭 1 / PHP 5.6 => launch tests OK Thank you for help 👍 |
At least it is fixed now :-)
|
Also update dev-master branch-alias to be in line with master branch