Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen doctrine/common requirement #2260

Closed
wants to merge 1 commit into from

Conversation

bburnichon
Copy link
Contributor

Also update dev-master branch-alias to be in line with master branch

@@ -13,7 +13,7 @@
],
"require": {
"php": ">=5.3.2",
"doctrine/common": ">=2.4,<2.6-dev"
"doctrine/common": "~2.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one. /cc @Ocramius

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move it to <2.7-dev

Also update dev-master branch-alias to be in line with master branch
@@ -28,7 +28,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "2.5.x-dev"
"dev-master": "2.6.x-dev"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is both unrelated, and unneeded. Composer only respects the alias on the actual master branch.

@Ocramius
Copy link
Member

Moved to #2268

@Ocramius Ocramius closed this Dec 25, 2015
Ocramius added a commit that referenced this pull request Dec 25, 2015
…ommon-requirement

#2260 - loosening doctrine/common requirement: allowing 2.6.x
@mickaelandrieu
Copy link

To be honest, this put your package with requirements >= PHP 5.4 cause doctrine/common 2.6.x requirements are php >= 5.5.

This force us (PrestaShop team) to explicitely declare the version of doctrine/common we want to require :( => PrestaShop/PrestaShop#5187

Is that intended ?

@Ocramius
Copy link
Member

This force us (PrestaShop team) to explicitely declare the version of doctrine/common we want to require :(

Uhhh... no? Composer will resolve to doctrine/common:2.5.x during composer update

@mickaelandrieu
Copy link

Uhhh... no? Composer will resolve to doctrine/common:2.5.x during composer update

Nope, with "doctrine/dbal": "~2.5.3" we get "doctrine/common": "2.6.1" and "doctrine/dbal" in 2.5.4.

@Ocramius
Copy link
Member

@mickaelandrieu that depends on the version of PHP that you have installed? People running Precambrian tech will simply get 2.5.* installed, as part of the resolved dependencies (within the range allowed by the constraints)

@mickaelandrieu
Copy link

@Ocramius weird, Composer does'nt works as expected on this point :/ We got a developper from our team able to install doctrine/common 2.6 with PHP 5.4 installed ..

But it's not related to your package, it's probably an issue of composer :/

Sorry for disturbing and thank you for your time :)

@Ocramius
Copy link
Member

@mickaelandrieu check CLI vs WEB envs

@mickaelandrieu
Copy link

Ok got it <3

We just forgot to update dependencies after switching php versions 🍭

1 / PHP 5.6 => launch tests OK
2 / switch to PHP 5.5 => launch tests OK
3 / switch to PHP 5.4 => launch tests KABOOM

Thank you for help 👍

@Ocramius
Copy link
Member

At least it is fixed now :-)
On Mar 14, 2016 18:40, "Mickaël Andrieu" notifications@github.com wrote:

Ok got it <3

We just forgot to update dependencies after switching php versions [image:
🍭]

1 / PHP 5.6 => launch tests OK
2 / PHP 5.5 => launch tests OK
3 / PHP 5.4 => launch tests KABOOM

Thank you for help [image: 👍]


Reply to this email directly or view it on GitHub
#2260 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants