Pass "path" to pdo-sqlite drivers from DriverManager instead of "dbname" #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the 'path' key the driver expects instead of the 'dbname' key other drivers expect.
| $nameKey = isset($url['scheme']) && strpos($url['scheme'], 'sqlite') !== false | ||
| ? 'path' // pdo_sqlite driver uses 'path' instead of 'dbname' key | ||
| : 'dbname'; | ||
|
|
||
| if (!isset($url['scheme']) || (strpos($url['scheme'], 'sqlite') !== false && $url['path'] == ':memory:')) { |
There was a problem hiding this comment.
Can we somehow try to avoid duplicate checks on whether the path is a sqlite path here?
Also I think it would be a good idea to consider setting memory parameter instead of path parameter, if the URL path refers to in-memory (it makes no difference for the driver but could be useful in userland when checking for specific parameters IMO).
Otherwise this patch looks good to me.
|
👍 |
deeky666
added a commit
that referenced
this pull request
Jan 8, 2016
Pass "path" to pdo-sqlite drivers from DriverManager instead of "dbname"
|
Merged manually, added evaluation of |
This was referenced Jan 10, 2016
|
@deeky666 do you have an ETA for a 2.5.5 release including this fix ? This would allow symfony/demo#297 (comment) to work. |
|
We need it as well as soon as possible 😄 Thanks. |
laoneo
added a commit
to joomla-x/joomla-pythagoras
that referenced
this pull request
May 5, 2016
When doctrine DBAl version 2.5.5 is released the change can be reverted, till then we need the commit doctrine/dbal@2c34559 from the PR doctrine/dbal#2267
klemens
added a commit
to klemens/StrigelCMS
that referenced
this pull request
Nov 13, 2016
This fixes a bug when using a sqlite connection string [1]. [1]: doctrine/dbal#2267
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1106. Any input on the correct way to do this per Doctrine coding standards is welcome.