Fix usage of PDO::PGSQL_ATTR_DISABLE_PREPARES for edge case pdo_pgsql setups #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setups not built from PHP core fixes doctrine#2249
Ocramius
added a commit
that referenced
this pull request
Jan 5, 2016
Fix usage of PDO::PGSQL_ATTR_DISABLE_PREPARES for edge case pdo_pgsql setups
Ocramius
added a commit
that referenced
this pull request
Jan 5, 2016
…nto 2.5 Backport #2273 to 2.5
|
Backported into 2.5 via 2bb8c06 |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant
PDO::PGSQL_ATTR_DISABLE_PREPARESis available since PHP 5.6.0, however this is only true if the extension is installed/built from the PHP core sources. Looks like in rare situations it is possible to run PHP 5.6 with a heavily outdatedpdo_pgsqlextension (coming from PECL?!?). In this case DBAL crashes.This PR makes the check for the constant's availability more robust to also work in those setups.
fixes #2249