Quote reserved keywords in TRUNCATE TABLE SQL #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeky666
added
Requires Review
IBM DB2
Platforms
PostgreSQL
Oracle
sqlanywhere
SQL Anywhere
SQLite
SQL Server
Quoting
Tables
and removed
sqlanywhere
labels
|
I feel like the $tableIdentifier = new Identifier(... stuff should have some sugar somewhere. Lots of repetition there... |
|
@zeroedin-bill totally agree. Had that in mind over the last few changes, too. But that should be done separately. |
billschaller
pushed a commit
that referenced
this pull request
Jan 12, 2016
Quote reserved keywords in TRUNCATE TABLE SQL
|
Backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2270