[DBAL-939] Fix reverse engineering boolean type columns on DB2 #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't know why postgres is suddenly failing again on PHP 5.6 but it seems very unrelated to this PR. |
|
Restarted the build: roll a dice. |
|
Meh. Try that also but no luck :( Not sure what's wrong there. But I didn't touch any postgres code so really no clue... |
- fixes platform's COMMENT ON statement support - implements reverse engineering for column comments - marks boolean column type commented for distinction fixes doctrine#2182
deeky666
added
IBM DB2
Platforms
Schema Management
Ready to Merge
and removed
Requires Review
labels
|
@Ocramius green nao :) |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2182
Fixing the original issue required fixing the partially implemented
COMMENT ONstatement support first. By fixing this issue, some missing tests have been added for all platforms, too.This also adds support for reverse engineering custom types as a side effect.