Fix parsing schemeless connection URLs #2287
Conversation
…river connection parameters - includes extended default driver connection parameter handling - minor refactoring fixes doctrine#1183
deeky666
added
Requires Review
Bug
Improvement
Drivers
PHP
Configuration
Connecting
labels
|
Fixed mocking zeh PDO |
| $url | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
I'd put this into a separate static method. To me only looking at this code it is not clear, that when $url is given here, it misses one special part. Maybe missingSchemeRequiredDriver() or something like that?
There was a problem hiding this comment.
Also no strong opinion here. @Ocramius @zeroedin-bill thoughts?
There was a problem hiding this comment.
Would have done a separate method as well, yep.
There was a problem hiding this comment.
Errata: seen now that 'url' may be passed in from multiple contexts. It is indeed better to let the exception class decide here.
|
Since this was my approach originally I left some comments :) Still somebody with a better feeling for the big picture should have a look. |
|
Merged, thanks @deeky666 and @kingcrunch! |
Taken over from and inspired by #863. Fixes #1183.
Also includes proper handling of the default driver connection parameters
pdo,driveranddriverClasswhen used together with connection URLs.Throws exception now if URL is given but neither URL scheme nor
driverparameter nordriverClassparameter is given. If also given a default PDO instance, DBAL would currently use that one instead and silently discard connection URL information.Finally I have done a minor refactoring of the connection URL parsing by simplifying the logic and splitting into smaller private methods. It is much more comprehensible now IMO. Also added a lot of comments to keep track of all the weird things that happen there :D