[Oracle] Fix list table columns when using external or OS authentication with Oracle #2318
Conversation
|
Requires tests |
|
I am on it |
butonic
force-pushed
the
master
branch
3 times, most recently
from
803c0ef
to
62452f3
Compare
|
@Ocramius I copied the |
| ), | ||
| ); | ||
| } | ||
| /** |
There was a problem hiding this comment.
Empty newline to be introduced here
|
@butonic @Ocramius hmm another funny Oracle story :D The fix seems a bit akward and tends to lead to additional checks against |
| $this->assertEquals($expectedSql, $this->_platform->getListTableColumnsSQL('"test"', $database)); | ||
| } | ||
|
|
||
| public function getReturnsGetListTableColumnsSQL() |
There was a problem hiding this comment.
We tend to avoid testing against complete SQL strings when it comes to testing getList*() Methods as those tests are fragile and need to be adjusted on every change in SQL. I would rather do a contains check in the string to check whether all_tab_columns or user_tab_columns is present (which is the interesting difference).
There was a problem hiding this comment.
Merging this regardless of the fragile test. We may simply rework the test, should some changes break this.
deeky666
changed the title
|
Btw this would also automatically fix other |
…-or-os-authentication-on-oracledb-2.5' into 2.5 Close #2318 Close DBAL-831
To use an external authentication mechanism, ef. Oracle Wallet you specify "/" us the db user and "" as the host when calling oci_connect. See http://php.net/manual/de/function.oci-connect.php#refsect1-function.oci-connect-parameters
This works as expected until you try to read the table columns with
getListTableColumnsSQL().Since
$databaseis "/" the code that should limit the listed columns to the given user actually prevents listing anything because a user "/" never exists.I did not find a test for
getListTableColumnsSQL()but am documenting the debug session that lead to this PR at https://github.com/owncloud/core/wiki/%5BWIP%5D-Oracle-Wallet