Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep references to bound parameter values in oci8 driver #2434

Merged
merged 1 commit into from
Jul 7, 2016
Merged

Keep references to bound parameter values in oci8 driver #2434

merged 1 commit into from
Jul 7, 2016

Conversation

deeky666
Copy link
Member

For PHP7 compatibility. The previously failing tests pass now.

Closes #2261
Closes #2262
Closes #2386

@deeky666 deeky666 added this to the 2.5.5 milestone Jun 30, 2016
Ocramius
Ocramius reviewed Jul 5, 2016
View reviewed changes
lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php
@@ -72,6 +72,15 @@ class OCI8Statement implements \IteratorAggregate, Statement
protected $_paramMap = array();

/**
* Holds references to bound parameter values.
*
* This is a new requirement for PHP7's oci8 extension.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should mention here that this is just to prevent GC to kick in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius better like this?

@soyuka soyuka mentioned this pull request Jul 6, 2016
Closed
@Ocramius Ocramius self-assigned this Jul 7, 2016
Ocramius added a commit that referenced this pull request Jul 7, 2016
@Ocramius
Merge branch 'hotfix/#2434-#2261-#2262-#2386-keep-bound-oci8-paramete…
e05f26d 
…rs-from-gc-2.5' into 2.5

Close #2434
Close #2261
Close #2262
Close #2386
@Ocramius Ocramius merged commit ae314b1 into doctrine:master Jul 7, 2016
Ocramius added a commit that referenced this pull request Jul 7, 2016
@Ocramius
Merge branch 'hotfix/#2434-#2261-#2262-#2386-keep-bound-oci8-paramete…
69b5785 
…rs-from-gc'

Close #2434
Close #2261
Close #2262
Close #2386
@Ocramius
Copy link
Member

Ocramius commented Jul 7, 2016

LGTM! 👍

Thanks @deeky666!

master: 69b5785
2.5: e05f26d

This was referenced Jul 7, 2016
Closed
Closed
@deeky666
Copy link
Member Author

deeky666 commented Jul 7, 2016

@Ocramius thanks for merging!

@Garfield-fr
Copy link

Thanks

@mmoll
Copy link

mmoll commented Jul 7, 2016

will there be a 2.5.5 soon?

@Ocramius
Copy link
Member

Ocramius commented Jul 7, 2016

@mmoll I'm probably allocating time next week to do a release.

@xalopp xalopp mentioned this pull request Aug 9, 2016
Closed
@Ocramius Ocramius mentioned this pull request Oct 1, 2016
Merged
1 task
@cjbj
Copy link

cjbj commented Oct 13, 2016

@Ocramius can you see if the proposed patch for PHP 7s' OCI8 in https://bugs.php.net/patch-display.php?bug_id=71148&patch=oci8-php7-bind&revision=latest removes the need for this workaround?

@Ocramius
Copy link
Member

Possibly, but it needs testing on that patch too (PHPT). The only negative side of this particular patch is that GC is shifted one level up (DBAL statement)

@Ocramius Ocramius mentioned this pull request Jan 11, 2017
Closed
@deeky666 deeky666 mentioned this pull request Feb 9, 2017
Closed
@mvorisek mvorisek mentioned this pull request Sep 13, 2020
Merged
@morozov morozov mentioned this pull request Oct 30, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Drivers oci8 Oracle PHP Prepared Statements
Projects
None yet
Milestone
2.5.5
Development

Successfully merging this pull request may close these issues.
5 participants
@deeky666 @Ocramius @Garfield-fr @mmoll @cjbj