Replace getMock() with createMock()
#2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deeky666 patch needs bumping PHPUnit dependency to at least |
|
Actually the issues fixed here were introduced because of that PR ;) |
|
@deeky666 indeed, thanks for pointing it out :-) |
Ocramius
changed the title
getMock() with createMock()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of bumping PHPUnit requirement to
^5.4.6in #2419 we get a lot of deprecation warnings forPHPUnit_Framework_TestCase::getMock()in our test suite.This PR fixes all of them. Also two tests had to be adjusted, because they were doing expectations on non-existing methods which PHPUnit now warns about.