Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date diff test #2635

Merged
merged 1 commit into from
Feb 6, 2017
Merged

Fix date diff test #2635

merged 1 commit into from
Feb 6, 2017

Conversation

deeky666
Copy link
Member

@deeky666 deeky666 commented Feb 6, 2017

The date diff test was broken because it did not truncate the time part for the expected value. This could lead to test failures if running the test at a certain time of the day.

See: https://continuousphp.com/git-hub/doctrine/dbal/build/aaa77206-8e4a-40d7-994e-506c9b41862c/output

@deeky666 deeky666 added this to the 2.5.12 milestone Feb 6, 2017
@Ocramius Ocramius self-assigned this Feb 6, 2017
@Ocramius Ocramius merged commit 4233051 into doctrine:master Feb 6, 2017
Ocramius added a commit that referenced this pull request Feb 6, 2017
@Ocramius
Copy link
Member

Ocramius commented Feb 6, 2017

Backported in 77b764a

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants