Fix result cache and PDO connection test on pdo_sqlsrv #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Feb 9, 2017
| // Emulated prepared statements have to be disabled for this test | ||
| // so that PDO actually communicates with the database server to check the query. | ||
| $this->driverConnection->setAttribute(\PDO::ATTR_EMULATE_PREPARES, false); | ||
| //$this->driverConnection->setAttribute(\PDO::ATTR_EMULATE_PREPARES, false); |
There was a problem hiding this comment.
Is this supposed to be commented out?
There was a problem hiding this comment.
No, good catch! Thanks you
deeky666
force-pushed
the
fix-pdo_sqlsrv-tests
branch
from
1779240
to
ec8a9d8
Compare
deeky666
force-pushed
the
fix-pdo_sqlsrv-tests
branch
from
ec8a9d8
to
a5b02c4
Compare
Ocramius
approved these changes
Feb 9, 2017
Ocramius
added a commit
that referenced
this pull request
Feb 9, 2017
…do-sqlsrv' into 2.5 Backport #2650 to 2.5.x
|
Backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The story continues...
This fixes two test cases where
pdo_sqlsrvfails.ResultCacheTest
Each test errors with that message. It is caused by the
setUp()which tries to create the test table and silences exceptions. There seems to be a bug in the driver, that leaves the connection in an erroneous state when managing exceptions in userland: microsoft/msphpsql#49 (comment)To make the tests pass for now, we correctly create the table on setup and drop it on teardown now.
PDOConnectionTest
pdo_sqlsrvfor some reason only supports settingPDO::ATTR_EMULATE_PREPARESon the statement object but not on the connection object, which makes the test useless (so skipping that one).