#2814 removing incorrect QueryBuilder#set() documentation, which was showing wrong password hashing and value binding practices (combo!)
#2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the code examples for `set()` to show that the value parameter is not escaped and thus could pose an SQL injection vulnerability.
Ocramius
approved these changes
Aug 18, 2017
| @@ -540,7 +540,7 @@ public function delete($delete = null, $alias = null) | |||
| * <code> | |||
| * $qb = $conn->createQueryBuilder() | |||
| * ->update('users', 'u') | |||
| * ->set('u.password', md5('password')) | |||
There was a problem hiding this comment.
OH WOW, we had md5('password') in the docs?! Shame on us :-(
There was a problem hiding this comment.
Oh, and no parameter binding: combo shame! :-\
|
LGTM 🚢 Thanks @Dormilich! |
|
Fixes #2814 |
Ocramius
changed the title
QueryBuilder#set() documentation, which was showing wrong password hashing and value binding practices (combo!)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the code examples for
set()to show that the value parameter is not escaped and thus could pose an SQL injection vulnerability.