Proofread types doc #2840
Merged
Proofread types doc #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
proofread_types_doc
branch
from
d4efd01
to
8fb8d37
Compare
Ocramius
suggested changes
Sep 11, 2017
docs/en/reference/types.rst
Outdated
| @@ -927,7 +927,10 @@ Now we implement our ``Doctrine\DBAL\Types\Type`` instance: | |||
| } | |||
| } | |||
|
|
|||
| The job of Doctrine-DBAL is to transform your type into SQL declaration. You can modify the SQL declaration Doctrine will produce. At first, you must to enable this feature by overriding the canRequireSQLConversion method: | |||
| The job of Doctrine-DBAL is to transform your type into SQL declaration. | |||
| You can modify the SQL declaration Doctrine will produce. First, you | |||
docs/en/reference/types.rst
Outdated
| @@ -927,7 +927,10 @@ Now we implement our ``Doctrine\DBAL\Types\Type`` instance: | |||
| } | |||
| } | |||
|
|
|||
| The job of Doctrine-DBAL is to transform your type into SQL declaration. You can modify the SQL declaration Doctrine will produce. At first, you must to enable this feature by overriding the canRequireSQLConversion method: | |||
| The job of Doctrine-DBAL is to transform your type into SQL declaration. | |||
There was a problem hiding this comment.
Or is that covered in the rest of this article?
There was a problem hiding this comment.
It is covered just below, on line 943
docs/en/reference/types.rst
Outdated
| @@ -937,7 +940,8 @@ The job of Doctrine-DBAL is to transform your type into SQL declaration. You can | |||
| return true; | |||
| } | |||
|
|
|||
| Then you override the methods convertToPhpValueSQL and convertToDatabaseValueSQL : | |||
| Then you override the methods ``convertToPhpValueSQL`` and | |||
There was a problem hiding this comment.
methods to be put at the end of this sentence
|
@Ocramius fixed, please review again |
|
continuousphp seems to be stuck... should I close and reopen? |
|
@greg0ire just amending/rebasing should restart continuousphp |
|
Clicking 2 buttons sounds easier :P |
|
It's unstuck :) |
|
ping @Ocramius |
Majkl578
approved these changes
Sep 20, 2017
|
Plz don't squash stuff unless needed 😅
…On 20 Sep 2017 04:45, "Michael Moravec" ***@***.***> wrote:
***@***.**** approved this pull request.
👍, maybe a single squashed commit instead of 6 would be cleaner
though... 😇
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2840 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakJIxT27TGDVKZE-DGdlFISRRmc_Rks5skHxcgaJpZM4PLI5Y>
.
|
|
@Majkl578 if the PR is easier to read like that then no squash is needed :P |
|
I've got nothing to add for this PR. 👍 |
It seems to be the case in the rest of this document.
greg0ire
force-pushed
the
proofread_types_doc
branch
from
f98a021
to
4a584f3
Compare
|
Rebased. |
Ocramius
approved these changes
Oct 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help making #2839 look less messy, and is far more mergeable.