Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Statement::fetch(PDO::FETCH_COLUMN) in non-PDO driveres #2964

Merged
merged 1 commit into from
Jan 7, 2018
Merged

Implemented Statement::fetch(PDO::FETCH_COLUMN) in non-PDO driveres #2964

merged 1 commit into from
Jan 7, 2018

Conversation

morozov
Copy link
Member

@morozov morozov commented Jan 5, 2018 •
edited
Loading

Fixes #2963.

Majkl578
Majkl578 reviewed Jan 7, 2018
View reviewed changes
lib/Doctrine/DBAL/Driver/Mysqli/MysqliStatement.php Outdated
@@ -272,6 +272,12 @@ public function fetch($fetchMode = null, $cursorOrientation = \PDO::FETCH_ORI_NE
return false;
}

$fetchMode = $fetchMode ?: $this->_defaultFetchMode;

if ($fetchMode == PDO::FETCH_COLUMN) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use === here (and below)?

tests/Doctrine/Tests/DBAL/Functional/StatementTest.php Outdated
@@ -282,4 +282,13 @@ function (Statement $stmt) {
),
);
}

public function testFetchInColumnMode()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: void

@Ocramius Ocramius added this to the 2.7.0 milestone Jan 7, 2018
@Ocramius Ocramius self-assigned this Jan 7, 2018
@Ocramius
Copy link
Member

Ocramius commented Jan 7, 2018

LGTM 👍

@Ocramius Ocramius merged commit a532697 into doctrine:master Jan 7, 2018
@Ocramius
Copy link
Member

Ocramius commented Jan 7, 2018

@morozov does this need a backport to 2.6.x?

@morozov morozov deleted the issues/2963 branch January 8, 2018 00:41
@morozov
Copy link
Member Author

morozov commented Jan 11, 2018

@Ocramius, yes.

@lcobucci lcobucci modified the milestones: 2.7.0, 2.6.4 Jan 12, 2018
@Ocramius
Copy link
Member

@lcobucci was this already backported? I didn't do that, so the milestone change may be incorrect until it's done.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Majkl578 Majkl578 Majkl578 approved these changes

Assignees

@Ocramius Ocramius

Labels
Bug Prepared Statements
Projects
None yet
Milestone
2.6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@morozov @Ocramius @Majkl578 @lcobucci