CS: correct annotation types to use symbols specified in the CS rules #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Jan 29, 2018
There was a problem hiding this comment.
Thank you @carusogabriel! Please see a couple alignment issues in comments.
lib/Doctrine/DBAL/Connection.php
Outdated
| @@ -356,7 +356,7 @@ public function getExpressionBuilder() | |||
| /** | |||
| * Establishes the connection with the database. | |||
| * | |||
| * @return boolean TRUE if the connection was successfully established, FALSE if | |||
| * @return bool TRUE if the connection was successfully established, FALSE if | |||
| * the connection is already open. | |||
There was a problem hiding this comment.
This one should be also moved 3 chars left.
| * @param integer|boolean $startPos Position to start at, beginning of string by default. | ||
| * @param string $str Literal string. | ||
| * @param string $substr Literal string to find. | ||
| * @param int|bool $startPos Position to start at, beginning of string by default. |
There was a problem hiding this comment.
I'm getting an error locally:
FILE: lib/Doctrine/DBAL/Platforms/AbstractPlatform.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
858 | ERROR | [x] Expected 1 spaces after parameter type; 4 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------And is not allow me to commit 😥
There was a problem hiding this comment.
You should un-indent the $str and $substr params.
|
🚢 (CI failure is a timeout in @travis-ci setting up the services) |
Ocramius
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @morozov in #2996