PHPUnit 7

[carusogabriel]

WIP as Symfony PHPUnit Bridge will need some compatibility.

[Majkl578]

ref symfony/symfony#26017 / symfony/symfony#26024

[Majkl578]

Blocking issues/PRs were closed/merged, anything else blocking now?

[carusogabriel]

@Majkl578 As mentioned in symfony/symfony#26139, Symfony still not compatible with PHPUnit 7. I have already used dev-master to test, but nothing for the moment. I'll rerun tests, but if continuous to fail, I'll close it and wait for them.

[morozov]

Can we just bump PHPUnit requirements on our end and update the bridge later? I see that we run PHPUnit directly and also have a dependency on it directly. What's the point of using the bridge?

[Majkl578]

What's the point of using the bridge?

Depecation notices + their testing I suppose, added in #2846.

[morozov]

Symfony still not compatible with PHPUnit 7.

In the bridge, I can't see any dependency on Symfony. Why is it an argument for not making the bridge compatible with PHPUnit 7 first?

[Majkl578]

Well, the bridge itself is part of Symfony so I guess it meant Symfony is not compatible, therefore the bridge is not compatible either.

[morozov]

When You Marry ‘The One,’ You Also Marry The Family… eh.

[Majkl578]

Okay, I pushed a fix to the suite & bumped requirement directly into @carusogabriel's branch (this PR). For now it depends on the bridge ^4.0.5@dev until Symfony releases stable version with proper PHPUnit 7 support.

[Majkl578]

Build is green except the lowest deps, those will be fixed once stable version is released and @dev dropped. 😊

[carusogabriel]

@Majkl578 Oh thanks, I was banging my head against version 3.x, while the solution was in 4.x 🎉

[Majkl578]

The fixes were merged into 3.4 and up so ^3.4.5|^4.0.5 would probably work too, but why keep it legacy for no reason, right? 😉

[Ocramius]

Can't 🚢 until this is an @dev

[Majkl578]

Yup, waiting for Symfony to release, will drop @dev after that.

[Majkl578]

Updated with the ^3.4.5|^4.0.5 constraint. Ready to land.

[Ocramius]

🚢