Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost parameters: wrong ESCAPED_BRACKET_QUOTED_TEXT #3277

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Lost parameters: wrong ESCAPED_BRACKET_QUOTED_TEXT #3277

merged 1 commit into from
Oct 21, 2018

Conversation

ohvitorino
Copy link

Q A
Type bug
BC Break yes
Fixed issues #3140

Summary

The first capturing group of the parser regex was stopping from the moment it would find a [ character. I expanded the original capturing group to include ARRAY[.*] as a capturable expression.

@ohvitorino
Copy link
Author

Still need to fix code style

@ohvitorino ohvitorino force-pushed the 3140-lost-parameters-wrong-ESCAPED_BRACKET_QUOTED_TEXT branch 3 times, most recently from 186c5d9 to b04a704 Compare September 2, 2018 13:20
@ohvitorino
Copy link
Author

Code styles are fixed, but one of the build jobs has failed.
It doesn't look like it has something to do with my code

$ phpenv global 7.2
rbenv: version `7.2' not installed
The command "phpenv global 7.2" failed and exited with 1 during .

@morozov
Copy link
Member

morozov commented Sep 7, 2018

@ohvitorino I've restarted the build.

@morozov
Copy link
Member

morozov commented Oct 14, 2018

@ohvitorino please rebase so that we could proceed.

@ohvitorino ohvitorino force-pushed the 3140-lost-parameters-wrong-ESCAPED_BRACKET_QUOTED_TEXT branch from b04a704 to fa7a9b6 Compare October 20, 2018 06:13
Include statements that contain the ARRAY[] notation
0a7d5f0 
The first capturing group of the parser regex was stopping form the moment it would find a `[` character.
@ohvitorino ohvitorino force-pushed the 3140-lost-parameters-wrong-ESCAPED_BRACKET_QUOTED_TEXT branch from e5ad7d6 to 0a7d5f0 Compare October 20, 2018 11:45
@ohvitorino
Copy link
Author

@morozov done!

@morozov morozov merged commit 77666f0 into doctrine:master Oct 21, 2018
@morozov morozov mentioned this pull request Oct 21, 2018
Closed
@morozov
Copy link
Member

morozov commented Oct 21, 2018

Thank you @ohvitorino!

morozov added a commit that referenced this pull request Oct 21, 2018
@morozov
Merge branch 'bpo/2.8/#3277' into 2.8
99f7a48
@SenseException SenseException mentioned this pull request Feb 26, 2019
Closed
@morozov morozov mentioned this pull request Mar 29, 2019
Closed
@morozov morozov self-assigned this Jun 7, 2019
@morozov morozov added this to the 2.9.0 milestone Jun 7, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

@Majkl578 Majkl578 Awaiting requested review from Majkl578

Assignees

@morozov morozov

Labels
Bug PostgreSQL Prepared Statements
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ohvitorino @morozov