[SQL Anywhere] Fix query limit values "0" and "null" #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Dec 4, 2018
deeky666
force-pushed
the
fix-sasql-offset-without-limit
branch
from
b581e4a
to
ec7b600
Compare
|
@Ocramius done |
Ocramius
suggested changes
Dec 4, 2018
deeky666
force-pushed
the
fix-sasql-offset-without-limit
branch
from
ec7b600
to
0f60b8f
Compare
deeky666
force-pushed
the
fix-sasql-offset-without-limit
branch
from
0f60b8f
to
6304d85
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integration tests on SQL Anywhere revealed that the platform doesn't handle
$limit = nullwhen rewritingSELECTstatements for LIMIT/OFFSET.Also handling of
$limit = 0was wrong as it was selecting ALL results instead of NONE.Reference: http://dcx.sybase.com/1200/en/dbreference/select-statement.html