Fixed AppVeyor build configuration and the issue on SQL Server #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
issues/3451
branch
2 times, most recently
from
8d6f358
to
29e806b
Compare
|
This is odd. The build is still passing, however, there's a lot of repositories using the same approach. It's also suggested in the documentation. |
morozov
force-pushed
the
issues/3451
branch
7 times, most recently
from
d3b870d
to
49c007b
Compare
PowerShell doesn't automatically handle exit codes of the invoked commands automatically, and $ErrorActionPreference = "Stop" doesn't seem working. Additionally, the ocular command is moved out of the "test_script" section to "after_test" since it's not part of the actual test.
|
An example of a failing job with the same AppVeyor configuration prior to the fix of SQL Server platform: 1.0.1445. |
morozov
changed the title
Ocramius
approved these changes
Feb 9, 2019
| @@ -1278,7 +1278,7 @@ protected function doModifyLimitQuery($query, $limit, $offset = null) | |||
| // Even if the TOP n is very large, the use of a CTE will | |||
| // allow the SQL Server query planner to optimize it so it doesn't | |||
| // actually scan the entire range covered by the TOP clause. | |||
| if (! preg_match('/^(\s*SELECT\s+(?:DISTINCT\s+)?)(.*)$/im', $query, $matches)) { | |||
| if (! preg_match('/^(\s*SELECT\s+(?:DISTINCT\s+)?)(.*)$/is', $query, $matches)) { | |||
There was a problem hiding this comment.
Woah, nice catch! Annoying that Powershell doesn't have a stricter default
|
@morozov does this need backporting? |
morozov
added a commit
that referenced
this pull request
Feb 9, 2019
|
I've backported the AppVeyor configuration changes, not sure yet about SQL Server yet. The test passed before the PHPStan-related changes even with the invalid regex flag. |
rgrellmann
added a commit
to Rossmann-IT/dbal
that referenced
this pull request
Apr 22, 2020
Release v2.9.3 [](https://travis-ci.org/doctrine/dbal) This release fixes regressions introduced in previous releases and other bugs. - Total issues resolved: **5** - Total pull requests resolved: **14** - Total contributors: **9** **Regressions** - [3686: Fixed query result caching when `FetchMode::COLUMN` is used](doctrine#3686) thanks to @morozov and @Junker - [3456: Compare type class when comparing columns.](doctrine#3456) thanks to @garret-gunter and @cs278 **Other bugs** - [3679: fix begin trasaction after reconnect](doctrine#3679) thanks to @kalinin-k-a - [3547: Default column expressions do not work on SQL Server](doctrine#3547) thanks to @morozov - [3420: Index length can be a `string`: ensure that it is an integer when read by the `MySqlSchemaManager`](doctrine#3420) thanks to @leofeyer **CI improvements and maintenance** - [3702: Updated SQL Server extensions to fix build failures on PHP 7.4](doctrine#3702) thanks to @morozov - [3662: Marked connection exception test incomplete on MySQL 8](doctrine#3662) thanks to @morozov - [3622: Switched from ibmcom/db2express-c to ibmcom/db2](doctrine#3622) thanks to @morozov - [3465: Replaced MySQL 5.7 installed from a PPA with an official Docker image](doctrine#3465) thanks to @morozov - [3454: CI: Test against PHP 7.4snapshot instead of nightly (8.0)](doctrine#3454) thanks to @Majkl578 - [3452: Fixed AppVeyor build configuration and the issue on SQL Server](doctrine#3452) thanks to @morozov and @Majkl578 - [3447: Replaced custom docker image for PostgreSQL with the official one](doctrine#3447) thanks to @morozov - [3407: CI: Test against MySQL 8.0 on Travis](doctrine#3407) thanks to @morozov **PHP 7.4 support** - [3642: Fixed test failures on PHP 7.4](doctrine#3642) thanks to @morozov # gpg: Signature made Sat Nov 2 23:20:42 2019 # gpg: using RSA key 374EADAF543AE995 # gpg: Can't check signature: public key not found
](https://travis-ci.org/doctrine/dbal){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3451.