Changed the type of $char in AbstractPlatform::getTrimExpression()from string|false to ?string #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
Mar 17, 2019
| "REVERSE(SUBSTR(REVERSE(SUBSTR(column, PATINDEX('%[^' + c + ']%', column))), PATINDEX('%[^' + c + ']%', " . | ||
| "REVERSE(SUBSTR(column, PATINDEX('%[^' + c + ']%', column))))))", | ||
| $this->platform->getTrimExpression('column', null, 'c') | ||
| ); |
There was a problem hiding this comment.
This case abuses the API and covers the same scenario as the following one.
Ocramius
suggested changes
Mar 17, 2019
…` from `string|false` to `?string`
Ocramius
approved these changes
Mar 18, 2019
morozov
pushed a commit
that referenced
this pull request
Mar 18, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
that referenced
this pull request
Apr 16, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
that referenced
this pull request
May 6, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
that referenced
this pull request
May 23, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
that referenced
this pull request
Jun 13, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
that referenced
this pull request
Jun 27, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
that referenced
this pull request
Jun 27, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
that referenced
this pull request
Jun 27, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
pushed a commit
that referenced
this pull request
Nov 2, 2019
Changed the type of $char in AbstractPlatform::getTrimExpression()`from string|false to ?string
morozov
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaking change is needed to enforce the type of
$charnatively to?string. The existing approach of usingfalseto specify the absence of a value is incorrect sincefalseis the opposite oftruewhich doesn't make sense as the value of$char, whilenullis exactly what should be used in this case.