Enable phpstan in DBAL tests

[jwage]

Q	A
Type	improvement
BC Break	no

Summary

Enable phpstan in DBAL tests.

[Ocramius]

Failures are only in CS:

FILE: tests/Doctrine/Tests/DBAL/Types/JsonTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 15 | ERROR | [x] Type RuntimeException is not used in this file.
    |       |     (SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse)
 18 | ERROR | [x] Type json_encode is not used in this file.
    |       |     (SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: tests/Doctrine/Tests/DBAL/Functional/TemporaryTableTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | ERROR | Class TemporaryTableTest contains write-only property
    |       | $tempTableCreated.
    |       | (SlevomatCodingStandard.Classes.UnusedPrivateElements.WriteOnlyProperty)
--------------------------------------------------------------------------------

[morozov]

I only noticed now that the PR targeted against develop. Since it's not supposed to contain breaking changes, should we retarget it against master?

[jwage]

I can try and see how hard it will be to rebase against master.

[jwage]

I don't think doing this against master will work because the changes made to the tests depend on all the type and api work that we did in develop.

[morozov]

At least we tried. Maybe it could be done later. It still would make sense to get it in master because this is where we get most of the code changes before 3.0 is released.