Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-3722] Revert removal of ?? $column breaking named parameters in OCI8 #3779

Closed

Conversation

beberlei
Copy link
Member

@beberlei beberlei commented Dec 7, 2019

Q A
Type bug
BC Break no
Fixed issues #3722

Summary

This reverts an accidental BC break with OCI8 support breaking named parameters.

Fixes #3722

@beberlei beberlei requested a review from morozov December 7, 2019 12:34
@Ocramius
Copy link
Member

Ocramius commented Dec 7, 2019

Possibly dupe of #3738?

@beberlei
Copy link
Member Author

beberlei commented Dec 7, 2019

Yes, but #3738 targets master and not 2.10, it adds new code instead of reverting to old code, and adds an exception that wasn't thrown before.

@michaljusiega
Copy link

michaljusiega commented Dec 7, 2019

I reported issue in #3766 but was closed too fast.

@beberlei
Copy link
Member Author

beberlei commented Dec 7, 2019

@michaljusiega the issue was closed by me because it was a duplicate of the same issue #3722

@morozov
Copy link
Member

morozov commented Dec 14, 2019

@beberlei please rebase to include the changes from #3778.

@morozov
Copy link
Member

morozov commented Dec 21, 2019

Closed in favor of #3738.

@morozov morozov closed this Dec 21, 2019
@morozov morozov self-assigned this Jan 22, 2020
@morozov morozov removed their request for review October 23, 2020 17:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants