Manual merge of 2.11.x into 3.0.x #4025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore all violations of the LowercasePHPFunctions sniff in SQLSrvStatement
The latest version is easier to understand for static analyzers.
We are testing what happens when providing the wrong type.
The method signature does not allow null.
Not all RDBMS have a concept of database, apparently (see SQLAnywhere). Those who do not should pass in a string to stay compatible with the signature.
That alone fixes 6 issues found by Psalm
This is what is expected with FETCH_COLUMN
This is precisely what we are testing here.
This hack is temporary and should be removed on 3.0.x
This return type is conditional to $params['wrapperClass']. Luckily, recent versions of Psalm allow documenting it properly. See vimeo/psalm#3277 Note that phpstan is not able to understand this yet, but still attempts to, hence the extra ignore rules.
It confuses both Psalm and PHPStan, and involves complicated mocking.
The php docs are not very clear about that one.
greg0ire
changed the title
|
@morozov this one is ready |
morozov
approved these changes
May 28, 2020
Moved rowCount() from Statement to ResultStatement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.