Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doctrine/coding-standard to 8.1 #4150

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 5, 2020

Q A
Type improvement
BC Break no

When upgrading to Coding Standard the 8.0 in #4050, I decided to upgrade only 2.11.x in order to not touch dependencies in 2.10.x but in practice having different coding standards in different supported versions creates extra merge conflicts during up-merges. Furthermore, the coding standard is a development dependency bumping which won't affect the package dependents.

@morozov morozov added this to the 2.10.3 milestone Jul 5, 2020
@morozov morozov requested a review from greg0ire July 5, 2020 21:39
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only dev dependencies so this is ok 👍

@morozov morozov merged commit 61a0113 into doctrine:2.10.x Jul 6, 2020
@morozov morozov self-assigned this Jul 6, 2020
@morozov morozov deleted the coding-standard-8.1 branch July 6, 2020 15:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants