Update locked composer/package-versions-deprecated for compatibility with PHP 8.0 #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
greg0ire
approved these changes
Aug 14, 2020
greg0ire
reviewed
Aug 14, 2020
| @@ -3547,5 +3555,5 @@ | |||
| "platform-overrides": { | |||
| "php": "7.3.0" | |||
| }, | |||
| "plugin-api-version": "1.1.0" | |||
| "plugin-api-version": "2.0.0" | |||
There was a problem hiding this comment.
This looks suspicious, but since the CI passes, I suppose this doesn't prevent using Composer 1 to install vendor packages like I thought it would.
There was a problem hiding this comment.
This looks suspicious
I used Composer 2 to make the update, so it's expected.
I suppose this doesn't prevent using Composer 1 to install vendor packages like I thought it would.
It shouldn't. It just guarantees that the dependencies were installed with Composer 2, and its plugin API is available for packages (e.g. Composer\PackageVersions). And it's only for CI anyways.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4200. See composer/package-versions-deprecated#7.